Use the Glean API directly when recording events
Categories
(DevTools :: General, task, P3)
Tracking
(Not tracked)
People
(Reporter: florian, Unassigned)
References
Details
nchevobbe asked to file this bug:
Could we file a bug (and reference it here), so we would directly pass the expected eventName here instead of manipulating the method + object here? This would probably help for grep-ability (there's around 60 calls to this function, this shouldn't be too complex to do)
(in this quote "here" means the recordEvent function in devtools/client/shared/telemetry.js)
To which I replied:
opening a follow-up to make the event names easily greppable is a good idea. If we could avoid the recordEvent helper function entirely, that would be even better. (If we want to keep the same processing for the extra fields, we could have a helper function generating the extra object).
[as it would let us benefit from the extra safety offered by the test I landed in bug 1919146]
|
||
Updated•5 months ago
|
Description
•