Closed Bug 192182 Opened 23 years ago Closed 23 years ago

editflagtypes uses ^ instead of **

Categories

(Bugzilla :: Bugzilla-General, defect)

2.17.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: bbaetz)

References

()

Details

Attachments

(1 file)

# Failed test (t/001compile.t at line 75) not ok 17 - editflagtypes.cgi --WARNING Possible precedence problem on bitwise ^ operator at editflagtypes.cgi line 432. editflagtypes.cgi syntax OK # Failed test (t/001compile.t at line 75) not ok 27 - importxml.pl --WARNING Using an array as a reference is deprecated at importxml.pl line 229. Using an array as a reference is deprecated at importxml.pl line 263. Using an array as a reference is deprecated at importxml.pl line 279. Using an array as a reference is deprecated at importxml.pl line 292. Using an array as a reference is deprecated at importxml.pl line 420. Using an array as a reference is deprecated at importxml.pl line 422. importxml.pl syntax OK
I don't see the ^ warning with 5.8.0. However, that should be **, not ^, anyway The other bug is bug 172331; morphing this one to match that warning/bug
Summary: Tinderbox "test failed" on bugzilla-tip on perl 5.8.0 → editflagtypes uses ^ instead of **
Target Milestone: --- → Bugzilla 2.18
Attached patch fix — — Splinter Review
65535 is way too long, but... FWIW, the current code actually read as: (length($::FORM{'description'}) < 2)^(16-1) which was always true (else we sould have errored out at 17/18)
Attachment #113852 - Flags: review?(gerv)
-> me justdave, you can r= and a= ths at the same time if you want :)
Assignee: justdave → bbaetz
Flags: approval?
Keywords: regression
Comment on attachment 113852 [details] [diff] [review] fix haven't tested, but the Camel agrees, and it's pretty obvious :) r=justdave
Attachment #113852 - Flags: review?(gerv) → review+
Flags: approval? → approval+
Checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: