1921830 - Move tab left/right should behave well with tab groups

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Stephen Thompson [:sthompson]]

Move tab left/right: Ctrl + Shift + PgUp/PgDown

Current behavior with 4 tabs (standalone 1, grouped 1, grouped 2, standalone 2):

With tab group not collapsed

• Standalone 1 active, Ctrl + Shift + PgDown results in the tab being inserted into the second position in the group (grouped 1, standalone 1 now in group, grouped 2, standalone 2)
• Grouped 2 active, Ctrl + Shift + PgDown results in the tab leaving the tab group and being inserted after standalone 2 (standalone 1, grouped 1, standalone 2, grouped 2 now standalone)

With tab group collapsed

• Standalone 1 active, Ctrl + Shift + PgDown results in the tab being inserted into the second position in the group (grouped 1, standalone 1 now in group, grouped 2, standalone 2), and the tab group remains collapsed
• Grouped 2 active, Ctrl + Shift + PgDown results in the tab leaving the tab group and being inserted after standalone 2 (standalone 1, grouped 1, standalone 2, grouped 2 now standalone), and tab group remains collapsed

Expected behavior:

• Tab should always move 1 position
• Tabs should continue to move into and out of tab groups that are not collapsed
• Tabs should skip over collapsed tab groups

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: Bug 1921830 - move active tab left/right into/out of tab groups r=dao,dwalker,jswinarton

Adds tab group contexts to the functionality behind keyboard shortcuts for moving the active tab left/right in the tab strip

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a071107a800e
move active tab left/right into/out of tab groups r=dao

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a071107a800e

Comment 6

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly and Beta builds.