Closed Bug 1921834 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 48384 - [shared storage] Validate context (frame attached) for createWorklet()

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox133 fixed)

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48384 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48384
Details from upstream follow.

Yao Xiao <yaoxia@chromium.org> wrote:

[shared storage] Validate context (frame attached) for createWorklet()

Problem: CheckBrowsingContextIsValid() is done in all places except
within createWorklet(). This could cause nullptr dereference error when
attempting to GetSharedStorageDocumentService().

This CL adds/moves the check to AddModuleHelper() to cover
createWorklet().

Bug: 368139440
Change-Id: Ied6fdbc0011f156229c3dc02a5e6bde244d508f6
Reviewed-on: https://chromium-review.googlesource.com/5893856
WPT-Export-Revision: 317b69540a8489f511442219b4f1eda1758bf36e

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76b9f79f8258 [wpt PR 48384] - [shared storage] Validate context (frame attached) for createWorklet(), a=testonly

https://hg.mozilla.org/mozilla-central/rev/76b9f79f8258

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.