Closed Bug 1921839 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48385 - createImageBitmap: Respect colorSpaceConversion for video

Categories

(Core :: Graphics: Canvas2D, task, P4)

Product:
Core
Component:
Graphics: Canvas2D
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48385 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48385
Details from upstream follow.

Christopher Cameron <ccameron@chromium.org> wrote:

createImageBitmap: Respect colorSpaceConversion for video

Plumb the parameter to reinterpret the video as being in sRGB from

  • blink::ImageBitmap::ImageBitmap (read from options)
  • blink::HTMLVideoElement::CreateStaticBitmapImage
  • blink::CreateImageFromVideoFrame
  • media::PaintCanvasVideoRenderer::Paint (via new parameter)

Add a WPT test for this. For the WPT test, add a Display P3 mp4 and
webm test video. (There exists a Rec2020 test video, but it is 10-bit,
which has bugs on some platforms, and uses the Rec709 transfer function,
which has different interpretations on all browsers).

Bug: 362431889
Change-Id: I3c12eb720b927a8e6466ab35ae29a044342df123

Reviewed-on: https://chromium-review.googlesource.com/5878044
WPT-Export-Revision: 65ba1b6ad1eb4fe2a39bf733bd6e4dc4ff139fff

Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 12 subtests

Status Summary

Firefox

OK : 6
PASS: 182
FAIL: 15

Chrome

OK : 6
PASS: 182
FAIL: 15

Safari

OK : 6
PASS: 178
FAIL: 19

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html [wpt.fyi]
    • createImageBitmap from an HTMLVideoElement, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement scaled down, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement scaled up, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement resized, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement with negative sw/sh, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL scaled down, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL scaled up, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL resized, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL with negative sw/sh, and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
  • /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html [wpt.fyi]
    • createImageBitmap from an HTMLVideoElement imageOrientation: "from-image", and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement imageOrientation: "flipY", and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "from-image", and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
    • createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "flipY", and drawImage on the created ImageBitmap: FAIL (Chrome: FAIL, Safari: PASS)
  • /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html [wpt.fyi]
    • createImageBitmap with CanvasRenderingContext2D image source.: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a97efe13563b [wpt PR 48385] - createImageBitmap: Respect colorSpaceConversion for video, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a97efe13563b

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.