1921937 - [InactiveCSS] incorrect inactive CSS on pseudo element when pseudo element node is selected

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to data:text/html,<meta charset=utf8><style>button::before { content: "d"; position: relative; top: 20px; }</style><button>hello</button>
2. Open the inspector
3. Select the button ::before node

Actual results

The top declaration is marked as inactive, although it is, since the element has position: relative

---

This was regressed by Bug 1583641

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1921937 - [devtools] Fix retrieval of computed style for pseudo element node. r=#devtools-reviewers.

When directly selecting the pseudo element in the markup view,
we were still passing the pseudo element as a second arguement
of getComputedStyle, which would not return the expected data.

A test case is added to ensure we don't regress this.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1583641

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1921937 - [devtools] Don't pass pseudo to _styleRef when handling inline style. r=#devtools-reviewers.

A test case is added to cover the fix.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7452beb2ca4
[devtools] Fix retrieval of computed style for pseudo element node. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/023a53a2e2b7
[devtools] Don't pass pseudo to _styleRef when handling inline style. r=devtools-reviewers,ochameau.

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/f7452beb2ca4
https://hg.mozilla.org/mozilla-central/rev/023a53a2e2b7

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1921937 - [devtools] Fix retrieval of computed style for pseudo element node. r=#devtools-reviewers.

When directly selecting the pseudo element in the markup view,
we were still passing the pseudo element as a second arguement
of getComputedStyle, which would not return the expected data.

A test case is added to ensure we don't regress this.

Original Revision: https://phabricator.services.mozilla.com/D224195

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1921937 - [devtools] Don't pass pseudo to _styleRef when handling inline style. r=#devtools-reviewers.

A test case is added to cover the fix.

Original Revision: https://phabricator.services.mozilla.com/D224347

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Erroneous inactive CSS information in the Inspector when selecting a pseudo element node
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: simple devtools only fix, covered by automated test
• String changes made/needed: -
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7527b155c878
https://hg.mozilla.org/releases/mozilla-beta/rev/cd17246b291d