Closed Bug 1921940 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48400 - Update fetchStart in resource timing when cache is used

Categories

(Core :: DOM: Service Workers, task, P4)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48400 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48400
Details from upstream follow.

Keita Suzuki <suzukikeita@chromium.org> wrote:

Update fetchStart in resource timing when cache is used

This CL updates fetchStart in resource timing when ServiceWorker static
routing API resource timing is used with cache as the actual source
type. This is to be compatible with other fields.

Explainer: https://github.com/WICG/service-worker-static-routing-api/blob/main/resource-timing-api.md
Bug: 41496865
Change-Id: I7c9b90f8be8cd7bef5d62edafb32b9f41448f18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900017
Reviewed-by: Takashi Toyoshima \<toyoshim@chromium.org>
Reviewed-by: Yoshisato Yanagisawa \<yyanagisawa@chromium.org>
Reviewed-by: Shunya Shishido \<sisidovski@chromium.org>
Commit-Queue: Keita Suzuki \<suzukikeita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1362229}

PR 48400 applied with additional changes from upstream: bf3c9f751607cc290c292f7b40ac32662d847935
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 14 subtests

Status Summary

Firefox

OK : 1
FAIL: 14

Chrome

OK : 1
FAIL: 14

Safari

OK : 1
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /service-workers/service-worker/tentative/static-router/static-router-resource-timing.https.html [wpt.fyi]
    • Main resource matched the rule with fetch-event source: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched with the condition and resource timing: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load not matched with the condition and resource timing: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched with the cache source and resource timing: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource fallback to the network when there is no cache entry and resource timing: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched the rule fetch-event source: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load not matched with URLPattern condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with URLPattern condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with the cache source rule: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load did not match with the cache and fallback to the network: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched the rule with race-network-and-fetch-handler source, and the fetch handler response is faster than the server response: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched the rule with race-network-and-fetch-handler source, and the server reseponse is faster than the fetch handler: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched the rule with race-network-and-fetch-handler source, and the fetch handler response is faster than the server response: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched the rule with race-network-and-fetch-handler source, and the server reseponse is faster than the fetch handler: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5875b187e8e [wpt PR 48400] - Update fetchStart in resource timing when cache is used, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.