1921963 - Enable exception handling assertions added in bug 1921780 everywhere

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jan de Mooij [:jandem]]

Bug 1921780 made uncatchable exceptions a bit more explicit and added assertions to catch some JSAPI footguns (bug 552007, bug 1408013).

I enabled this only for the JS shell initially, but if this is green in fuzzing we should enable the assertions everywhere.

Comment 1

[Jan de Mooij [:jandem]]

As I expected, there is some orange here: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=5e6ab3cf16ad0aa3fa3b12b0736edbd510104bf6

These are either places where Gecko is reporting uncatchable exceptions and it just needs to use the new API, or they're caused by bugs where it's unintentionally throwing uncatchable exceptions.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1921963 part 1 - Use JS::ReportUncatchableException more outside the JS engine. r?arai!

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1921963 part 2 - Enable exception handling assertions everywhere. r?arai!

Comment 4

[Jan de Mooij [:jandem]]

With two more ReportUncatchableException calls the browser tests are looking suspiciously green... Here goes nothing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6d212df870
part 1 - Use JS::ReportUncatchableException more outside the JS engine. r=arai

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bdbbd942d48
part 2 - Enable exception handling assertions everywhere. r=arai

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ed6d212df870

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5bdbbd942d48