1922014 - Don't emit "browsingContext.navigationStarted" event when creating new top-level browsing contexts (tabs) when "about:blank" is loaded

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When executing the command browsingContext.create we currently send out navigation events like browsingContext.navigationStarted even for the initial about:blank. As discussed during TPAC (https://github.com/w3c/webdriver-bidi/issues/766) we should align to other browsers and as well follow the HTML specification which doesn't say that navigation events should be emitted.

This should also apply to evaluating a script that runs window.open() for about:blank.

But normal navigations to about:blank should not be affected.

Comment 1

[Dan]

@whimboo So webdriver bidi, I see the constructor for browsingContext emits the nnavigationStarted event, which is a private method. The browsingContext.Create doesn't emit the navigationStarted event itself. So what we are trying to do here is to remove this right?

Comment 2

[Dan]

Attachment: Bug 1922014 - Don't emit navigation events when creating new top-level browsing contexts (tabs) when "about:blank" is loaded. r?whimboo

Comment 3

[Julian Descottes [:jdescottes]]

Per discussion on phabricator, resetting the bug

Comment 4

[Alexandra Borovova [:Sasha]]

Keeping this bug just about skipping "browsingContext.navigationStarted" event and moving load events to a follow-up bug 1930594.

Comment 5

[Alexandra Borovova [:Sasha]]

Just to document the spec state:

In the browsing context creation algorithm there are no navigation steps, we are only supposed to set about:blank to certain context properties, this means that we don’t get to the step of sending browsingContext.navigationStarted event.
In case of window.open, in the window open steps algorithm we're supposed to create a top browsing context (so the behavior is similar to the case described above) and then navigate or update history to a desired URL, but as it says in the note in the step 6 we shouldn't do anything if the url fully matches about:blank. Which means that again we shouldn't emit browsingContext.navigationStarted event.
We should still send browsingContext.navigationStarted event when a client navigates to it outside a top-level context creation.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1922014 - [bidi] Don't emit "browsingContext.navigationStarted" event when creating a new top-level browsing contexts when "about:blank" is loaded.

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1922014 - [wdspec] Add tests for "browsingContext.navigationStarted" event when a top-level browsing context get created.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db7391afb2a2
[bidi] Don't emit "browsingContext.navigationStarted" event when creating a new top-level browsing contexts when "about:blank" is loaded. r=webdriver-reviewers,whimboo,jdescottes
https://hg.mozilla.org/integration/autoland/rev/d5f3b0175c7f
[wdspec] Add tests for "browsingContext.navigationStarted" event when a top-level browsing context get created. r=webdriver-reviewers,whimboo

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49220 for changes under testing/web-platform/tests

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/db7391afb2a2
https://hg.mozilla.org/mozilla-central/rev/d5f3b0175c7f

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot