Closed
Bug 1922048
Opened 1 year ago
Closed 1 year ago
Bug in upstream echo_canceller3.cc - comma in place of semicolon
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
133 Branch
| Tracking | Status | |
|---|---|---|
| firefox133 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
Details
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/third_party/libwebrtc/modules/audio_processing/aec3/echo_canceller3.cc#780-788 has a bug found by noticing a clang warning -- the second assignment in this list ends with a comma instead of a semicolon. This bug is still extant in upstream source. The previous import of upstream didn't have this bug.
We should fix it and upstream the fix.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Pushed by rjesup@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd7a2f8d10cf
fix comma instead of semicolon in libwebrtc AEC code r=mjf,webrtc-reviewers
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•