1922050 - ThirdPartyUtil::GetBaseDomainFromSchemeHost should check if the scheme is "file"

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[edgul]

ThirdPartyUtil::GetBaseDomainFromSchemeHost should check if the scheme is "file".
If it is then call aBaseDomain.Truncate(), otherwise check if the base domain is empty and return an error if so.
https://searchfox.org/mozilla-central/rev/4cef3cd672243f7ae6d46103ca0ea7b253a74484/dom/base/ThirdPartyUtil.cpp#468-470

Comment 1

[edgul]

I was looking for the best way to add a test for this function, but noticed we only have one caller of this function: https://searchfox.org/mozilla-central/rev/691fb5ba2d1022cfe3fdc7b68e9460395c792300/netwerk/base/mozurl/src/lib.rs#345

and maybe this function shouldn't need to exist anymore?
https://searchfox.org/mozilla-central/rev/691fb5ba2d1022cfe3fdc7b68e9460395c792300/netwerk/base/mozIThirdPartyUtil.idl#167-168

An alternative might remove this method and use whichever one that was added as a replacement in Bug 922464.

Valentin, any thoughts?

Comment 2

[Valentin Gosu [:valentin] (he/him)]

I think we can remove it along with mozurl_base_domain and the callsites in the gtest

Comment 3

[edgul]

Attachment: Bug 1922050 - Removed unused GetBaseDomainFromSchemeHost from thirdparty util r?valentin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/390c9d9ac548
Removed unused GetBaseDomainFromSchemeHost from thirdparty util r=valentin,necko-reviewers

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/390c9d9ac548