192218 - Need a way to filter specifically for requests with no requestee

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Dave Miller [:justdave]]

Currently the only way to do this is grab all requestees and sort by requestee
so you get them grouped at the top.  It would be nice to have a way to query for
only requests with no requestee.

Comment 1

[Frédéric Buclin]

Attachment: use "*" for requests from the wild

For backward compatibility, an empty requestee field considers everything,
including requests with no requestee (nothing is specified, so take
everything).
Writing "*" (without quotes) specifically considers requests with no requestee
(* usually means anything, but here in the sense anybody not explicitly
defined, i.e. no requestee).

Comment 2

[Frédéric Buclin]

Comment on attachment 162911 [details] [diff] [review]
use "*" for requests from the wild

simple patch

Comment 3

[Dave Miller [:justdave]]

I really don't like the *...  it sounds like a wildcard.  How about a hyphen (or
two or three?)  We use that convention already elsewhere in Bugzilla (for no
resolution, no priority, no target milestone, etc)

Comment 4

[Frédéric Buclin]

(In reply to comment #3)
> I really don't like the *...  it sounds like a wildcard.  How about a hyphen (or
> two or three?)

I don't like it either.

Then, why not a checkbox under the requestee textbox named "No requestee"? If
checked, the requestee field would be grayed.

Adding myk to the CC list as I asked him to review my patch.

Comment 5

[Frédéric Buclin]

Attachment: use a hyphen for requests with no requestee + tool tip

replacing "*" by a hyphen "-" and adding a tool tip so that users have a chance
to know that this option now exists. For consistency, I also add a tool tip to
the requester field.

myk suggests that if this feature becomes popular, we could later add a
checkbox making it more accessible.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 163061 [details] [diff] [review]
use a hyphen for requests with no requestee + tool tip

>Index: mozilla/webtools/bugzilla/request.cgi

>+        if ($cgi->param('requestee') ne "-") {
>+            push(@criteria, "requestees.login_name = " . SqlQuote($cgi->param('requestee')));
>+        }
>+        else { push(@criteria, "flags.requestee_id IS NULL") }

Nit: when the "if" execution block of an "if-else" statement resides on its own
indented lines, the statement is easier for me to read if the "else" execution
block also resides on its own indented lines, even if it's short.  Otherwise my
eyes tend to gloss over and miss the else block entirely, and I suppose other
Bugzilla coders may do the same.


>Index: mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl

>-      <td><input type="text" name="requester" value="[% cgi.param('requester') FILTER html %]" size="20"></td>
>+      <td><input type="text" name="requester" value="[% cgi.param('requester') FILTER html %]" size="20" title="Requester's email address"></td>

>-      <td><input type="text" name="requestee" value="[% cgi.param('requestee') FILTER html %]" size="20"></td>
>+      <td><input type="text" name="requestee" value="[% cgi.param('requestee') FILTER html %]" size="20" title="Requestee's email address or ''-'' (hyphen) for requests with no requestee"></td>

Nit: these lines would be better off wrapped, and the quotes around the hyphen
would be better inserted with &quot; instead of using two single-quotes.

Otherwise this looks good, and all issues nits, so r=myk.

Comment 7

[Frédéric Buclin]

Attachment: use a hyphen for requests with no requestee + tool tip, v1.1

same patch as before, using " and wrapping long lines.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 163067 [details] [diff] [review]
use a hyphen for requests with no requestee + tool tip, v1.1

>+      <td><input type="text" name="requester" value="[% cgi.param('requester') FILTER html %]" size="20" 
>+           title="Requester's email address"></td>

Minor nit: Bugzilla code generally lines up wrapped attributes with the
attributes on the previous line, i.e.:

+      <td><input type="text" name="requester" value="[% cgi.param('requester')
FILTER html %]" size="20" 
+		  title="Requester's email address"></td>

Comment 9

[Myk Melez [:myk] [@mykmelez]]

This is a nice low-risk fix that would be good to go into 2.20.

Comment 10

[Vlad Dascalu]

Since it seems the whole file could use some identation clean-up, I left myk's
minor nit for another patch.

Checking in request.cgi;
/cvsroot/mozilla/webtools/bugzilla/request.cgi,v  <--  request.cgi
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v
 <--  queue.html.tmpl
new revision: 1.11; previous revision: 1.10
done

Comment 11

[victory <[e-mail]>]

Attachment: docs patch for 2.20 v1

it seems no docs for searching flags so that will be needed but isn't this bug.

Comment 12

[timeless]

Comment on attachment 207862 [details] [diff] [review]
docs patch for 2.20 v1

you need a blank line between </para> and <para>.

> Open flags those requester/requestee is you can be seen from 'My Requests' on the footer. 

This is not an English sentence.

You can browse through open requests made of you and by you by selecting 'My Requests' from the footer. 

XXX what if the footer is actually not the footer?

> You can also query other requester / requestee from this page. 

Don't use "query", try "browse" or "search"

Something like:
You can also look at open requests limited by other requesters, requestees, products, components, and flag names from this page. 

> Note that you can use '-' for requestee to specify flags those are 'no requestee' set. 

Change "those are" to "with"

Comment 13

[victory <[e-mail]>]

Attachment: docs patch for 2.20 v2

take timely's comment

Comment 14

[Frédéric Buclin]

Documentation:

tip:

Checking in docs/xml/using.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/using.xml,v  <--  using.xml
new revision: 1.37; previous revision: 1.36
done

2.20:

Checking in docs/xml/using.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/using.xml,v  <--  using.xml
new revision: 1.33.2.3; previous revision: 1.33.2.2
done