1922190 - Highlighter related warning message (Layout was forced before the page was fully loaded) is displayed in regular console

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://www.playorama.app/
2. Open the inspector
3. Open the split console
4. Reload the page

Actual results

The following warning message is displayed : Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content. markup.js:250:53

The message is triggered by the highlighters: https://searchfox.org/mozilla-release/rev/bad2bcb1b74cce00563fde8aab67ae924befe3c2/devtools/server/actors/highlighters/utils/markup.js#247-252

// If we didn't wait for the document to load, we want to force a layout update
// to ensure the anonymous content will be rendered (see Bug 1580394).
const forceSynchronousLayoutUpdate = !this.waitForDocumentToLoad;
this._content = this.anonymousContentDocument.insertAnonymousContent(
  forceSynchronousLayoutUpdate
);

We should not print highlighter-related warning/error messages to regular webconsole.

---

Reported on Mastodon: https://mastodon.social/@HTeuMeuLeu/113232651506510579

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1922190 - [devtools] Avoid forcing layout when creating ViewportSizeOnResizeHighlighter. r=#devtools-reviewers.

The highlighter is created when the inspector
is initialized and we were forcing a layout update
since we're not waiting for the page to load.
This was displaying a warning message in the console
that could confuse end users, and worse, trigger
animations when people didn't expected them to be.

To fix this, we add a new option in CanvasFrameAnonymousContentHelper
to control the layout update.

Comment 2

[Julian Descottes [:jdescottes]]

Thanks for working on this Nicolas, do you think we should close Bug 1924725 and Bug 1925126 as duplicates?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/446043706a5d
[devtools] Avoid forcing layout when creating ViewportSizeOnResizeHighlighter. r=devtools-reviewers,bomsy.

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/446043706a5d

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-10-02 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 134.0a1 and Firefox 133.0 on Windows 10, Ubuntu 22, macOS 14.