1922250 - Black borders around the browser Window on startup (Bug 1893918 has returned)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Mayank Bansal]

Start Firefox

AR: As the browser opens, there is a flash of black border around the window.
ER: Not so.

Bisection:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7e482cc8bf9e5adfe593baa0ced722d05dbf34a7&tochange=9fd8ea4ffcea09d84de86001d2da9d2e04660cad

Strong suspect: bug 1911763

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Attachment: bandicam 2024-10-02 18-42-18-494.mp4

Comment 3

[Mayank Bansal]

I'm surprised nobody using windows noticed and filed a bug.

Comment 4

[Mayank Bansal]

Attachment: log.txt-main.18992.moz_log

Logfile with "Windows" preset.
I started the browser and then enabled the logging. Then I pressed "Ctrl + N" to create a new Window (that had the black border)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1911763

:emilio, since you are the author of the regressor, bug 1911763, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox133 (nightly). However, the bug still isn't assigned.

:gcp, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I plan to look, yeah...

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1922250 - Do not force-clear the nc-area after consuming the skeleton UI window. r=#win-reviewers

If we get a paint message in-between we set the attributes and we call Show(),
we might still incorrectly clear the NC area, even though we're still
displaying the blank window.

While debugging this I realized mShowingSkeletonUI is a bit of a misnomer,
see the comment there...

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1922250 - Initialize some fields in nsWindow.h. r=#win-reviewers

Drive-by. These get set in nsWindow::Create but probably best to avoid
uninitialized memory.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1922250 - Align skeleton ui with nsWindow more closely. r=#win-reviewers

This maps better to the code we have in nsWindow, and fixes a couple
bugs which caused maximized skeleton UI-consuming windows to be
mispositioned with the following patches.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1922250 - Make skeleton UI special cases not modify mBounds incorrectly. r=#win-reviewers

We're not resizing the window, so we shouldn't change mBounds.

These are all super-hacky btw, ideally we expose some code to
sessionrestore to do the right thing, then remove this.

But for now this would do.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bf4bf1a74b1
Initialize some fields in nsWindow.h. r=win-reviewers,rkraesig

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1bf4bf1a74b1

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7ebee651e07
Align skeleton ui with nsWindow more closely. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/9af0852c057c
Make skeleton UI special cases not modify mBounds incorrectly. r=win-reviewers,rkraesig

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4e18a092cba
Make sure mBounds is correct after consuming maximized skeleton UI. r=fix. CLOSED TREE

Comment 16

[Noemi Erli[:noemi_erli]]

Emilio, the follow-up did not work, it caused another perma, so had to backout entire bug, sorry about that

Backed out 3 changesets (Bug 1922250) for causing failures in browser_1446343-windowsize.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=EATysuy8QN26FSmFnMGdkw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=windows%2C11%2Cx64%2C22h2%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-windows11-64-2009-qr%2Fdebug-mochitest-browser-chrome%2Cbc12&revision=f4e18a092cbab8c7d58859a240e8d918aa185399

Log: https://treeherder.mozilla.org/logviewer?job_id=477973210&repo=autoland&lineNumber=13409

Backout: https://hg.mozilla.org/integration/autoland/rev/c62072ea1e6f851d71730472e8bf91011d53623e

Comment 17

[Emilio Cobos Álvarez (:emilio)]

No worries, thanks!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97dce070567f
Align skeleton ui with nsWindow more closely. r=win-reviewers,rkraesig

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/97dce070567f

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61ba9f82e228
Make skeleton UI special cases not modify mBounds incorrectly. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/ae53bce6521b
Do not force-clear the nc-area after consuming the skeleton UI window. r=win-reviewers,rkraesig

Comment 21

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/61ba9f82e228
https://hg.mozilla.org/mozilla-central/rev/ae53bce6521b

Comment 22

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I am still able to reproduce the issue on Firefox 133.0b9 and Firefox Nightly 134.0a1 (2024-11-17), using Windows 11, as described in Comment 0. I am also able to reproduce it with the builds from Comment 21.
@Emilio, should we reopen this or we can continue to track it in bug 1927460? Thanks in advance!

Comment 23

[Emilio Cobos Álvarez (:emilio)]

To be clear, can you reproduce it on a non clean profile? That should be fixed afaict. What you're seeing is likely bug 1927460.

Comment 24

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I am unable to reproduce the issue with older profiles, but if I create a new profile, generate some navigation data, and then quit/reopen the browser, I am seeing the black border a few times (5 or 6 times). After that, the issue is no longer reproducing. Please see the screen recording (the file was to large to attach it): https://drive.google.com/file/d/1IOnMp9j13hJk75XpDEpfaAUwiBSxehUh/view?usp=sharing

Comment 25

[Emilio Cobos Álvarez (:emilio)]

Ok, I think using the restart button might not use the PreSkeletonUI, so that is bug 1927460 indeed. Let's track it there, it's good to have such an easy repro, thanks!

Comment 26

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Thank you for the confirmation as well!
Removing the "qe-verify+" flag.