1922301 - Make sure view transition pseudo-elements are not exposed to a11y.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez [:emilio]]

I suspect this should be as easy as making the view transition root have aria-hidden or so, but worth tracking in case it's larger.

Writing a test might take some work too.

Comment 1

[Boris Chiou [:boris]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #0)

I suspect this should be as easy as making the view transition root have aria-hidden or so, but worth tracking in case it's larger.

Writing a test might take some work too.

Yap. Just checked the spec again to make sure this:

• Elements participating in a view transition are exposed to accessibility tree. See issue 9365.
• The view transition tree is not exposed to accessibility tree. See issue 9365.

First, I cannot see the pseudo-element tree on the Devtools panel (accessibility tab), and also, I tried to check if our pseudo elements are accessible by the following API (code):

if (nsAccessibilityService* accService = GetAccService()) {
  printf_stderr("%s\n", accService->HasAccessible(node)?"true":"false"); // node is the snapshot cb, ::view-transition, ::view-transition-image-pair, ::view-transition-new, or ::new-transition-old
}

This API checks if this nsINode has an accessible or not. It seems all of the view transition pseudo-elements are not accessible (per our current implementation). So we probably don't need to add aria-hidden.

However, we still need a test for this.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1922301 - Add test to make sure the view transition tree is not exposed to the accessibility tree.

We don't expose the view transition tree to the accessibility tree per
our current implementation, so this patch only adds the test.

In the test, we use iframe to make the document simpler. We shouldn't
see any view transition pseudo-elements in the tree.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1922301 - Add test to make sure the view transition tree is not exposed to the accessibility tree.

We don't expose the view transition tree to the accessibility tree per
our current implementation, so only a test in this patch.

In the test, we use iframe to make the document simpler. We shouldn't
see any view transition pseudo-elements in the tree.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ae1fcea8deb
Add test to make sure the view transition tree is not exposed to the accessibility tree. r=morgan,view-transitions-reviewers,emilio

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3ae1fcea8deb