1922316 - Only set sidebar nimbus prefs with a minVersion check

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: needed to support experiment enrolling 132 -> upgrade to 133

Building on the ability to flip prefs from bug 1895932, we want to conditionally set these prefs depending on the current firefox version so that we can pre-enroll users during 132 without changing the experience until upgrading to 133. This should be copying the chatbot functionality from bug 1916274:

if (
  Services.vc.compare(
    AppConstants.MOZ_APP_VERSION_DISPLAY,
    lazy.NimbusFeatures[featureId].getVariable("minVersion")
  ) < 0
) {
  return;

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1922316 - Only set sidebar nimbus prefs with a minVersion check

Add minVersion feature variable to check against current firefox version.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/542c9391430f
Only set sidebar nimbus prefs with a minVersion check r=sidebar-reviewers,sclements,Gijs

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/542c9391430f

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1922316 - Only set sidebar nimbus prefs with a minVersion check

Add minVersion feature variable to check against current firefox version.

Original Revision: https://phabricator.services.mozilla.com/D224356

Comment 5

[Ed Lee :Mardak]

verified with stage preview https://stage.experimenter.nonprod.dataops.mozgcp.net/nimbus/mardak-test-chatbot-minversion and a changing the firefox version from 133.0a1 to 133.0a2

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: users enrolled during 132 experience pre-133 feature
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: manually verified with stage preview experiment, experiment testing will cover
• Risk associated with taking this patch: low
• Explanation of risk level: only runs for experiment with new logic to skip
• String changes made/needed: none
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbbe6720b887