1922327 - Wrong navigation id in browsingContext.load if the page performs a fragment or same-document navigation

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

See https://github.com/puppeteer/puppeteer/issues/13041#issuecomment-2389033038

Potentially regressed by Bug 1879163, but overall the navigation manager is storing the latest navigation id in a map, and this is used by various events (eg domContentLoaded, load etc...) in order to know to which navigation they are linked.

What happens in this scenario, loading google.com is:

• navigate command sent
• navigationStarted event with id A
• same document navigation detected for google.com with id B
• domContentLoaded emitted with navigation id B
• load emitted with navigation id B

Comment 1

[Julian Descottes [:jdescottes]]

It is relatively easy to align Firefox on Chrome's behavior here. The overall idea is that a fragment or same-document navigation should not override the ongoing navigation id of a regular navigation. Those "instant" navigations don't really relate to the upcoming domContentLoaded/load events, so we should just avoid storing them if there is already an ongoing navigation.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1922327 - [bidi] Do not override ongoing navigations with fragment or same document navigation ids

Fragment and same-document navigations could override an ongoing navigation and lead browsing
context events such as load and domContentLoaded events to no longer be linked to the expected navigation
id.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1922327 - [wdspec] Add test for load event after early same document navigation

Depends on D224385

Comment 4

[Julian Descottes [:jdescottes]]

File a spec issue to check the correctness

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b87f575c8d1
[bidi] Do not override ongoing navigations with fragment or same document navigation ids r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/eb9f5edc1307
[wdspec] Add test for load event after early same document navigation r=webdriver-reviewers,Sasha

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48537 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9b87f575c8d1
https://hg.mozilla.org/mozilla-central/rev/eb9f5edc1307

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

(In reply to Julian Descottes [:jdescottes] from comment #4)

File a spec issue to check the correctness

Hi Julian, I assume this spec issue still needs to be filed?

Comment 10

[Julian Descottes [:jdescottes]]

I read the spec again, and the navigation id we are supposed to receive in the navigate command is specifically the during-loading navigation ID for WebDriver BiDi (https://html.spec.whatwg.org/#concept-document-navigation-id) which is set on the when the navigation starts.

So it should not indeed be affected by same document navigations occurring during the actual navigation.