1922340 - Removal of strings marked as unused for version 124 and 125

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[[:skhan]]

We should also remove strings marked as moz:removedIn=“124” and moz:removedIn=“125” since a few of those strings were missed during our monthly beta cuts

Comment 1

[[:skhan]]

Attachment: Bug 1922340 - Removal of unsused strings

Comment 2

[Petru-Mugurel Lingurar [:petru]]

With Firefox Release now being at v. 131
According to https://firefox-source-docs.mozilla.org/mobile/android/fenix/Working-with-Strings.html
Following the beta cuts shouldn't we have removed all strings marked as removed in <= v. 130 ?
I see there are quite a few of these.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd7a41654acb
Removal of unsused strings r=android-reviewers,gmalekpour

Comment 4

[[:skhan]]

:petru yes, a few of these were missed and were handled in a second patch https://phabricator.services.mozilla.com/D224366

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/bd7a41654acb

Comment 6

[Titouan Thibaud [:titouan]]

Attachment: Bug 1922340 - Remove remaining string with moz:removedIn="124"

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32d573733625
Remove remaining string with moz:removedIn="124" r=android-reviewers,skhan

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/32d573733625

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)