Closed Bug 1922340 Opened 5 months ago Closed 5 months ago

Removal of strings marked as unused for version 124 and 125

Categories

(Fenix :: General, task)

All
Android
task

Tracking

(firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: skhan, Assigned: skhan)

Details

Attachments

(2 files)

We should also remove strings marked as moz:removedIn=“124” and moz:removedIn=“125” since a few of those strings were missed during our monthly beta cuts

With Firefox Release now being at v. 131
According to https://firefox-source-docs.mozilla.org/mobile/android/fenix/Working-with-Strings.html
Following the beta cuts shouldn't we have removed all strings marked as removed in <= v. 130 ?
I see there are quite a few of these.

Pushed by sarahkhan1107@hotmail.com: https://hg.mozilla.org/integration/autoland/rev/bd7a41654acb Removal of unsused strings r=android-reviewers,gmalekpour

:petru yes, a few of these were missed and were handled in a second patch https://phabricator.services.mozilla.com/D224366

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Pushed by tthibaud@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32d573733625 Remove remaining string with moz:removedIn="124" r=android-reviewers,skhan

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: