1922379 - [UX Follow] Add error message for when too many characters are selected before selecting a prompt

Status: VERIFIED FIXED

(Core :: Machine Learning: General, enhancement, P1)

Description

[Eric Pang [:epang] UX]

We currently truncate what is sent to the provider (different limits for each provider) without letting the user know.
An error message needs to be added so that the user is aware that only a portion of their selected text will be sent to the prompt.

See UX spec here

Comment 1

[Ed Lee :Mardak]

new strings and styling for conditionally showing message based on provider and selection. some logic probably will be approximated similar to bug 1903900 especially with custom prompt could reduce how much selection is sent (custom prompt could be much longer than selection)

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1922379 - Add error message for when too many characters are selected before selecting a prompt r=Mardak!

Use moz-message-bar warning to conditionally show long selection warning.

Comment 3

[Ed Lee :Mardak]

the strings we want are updated in the figma from comment 0:

[Provider] won’t get your full selection
You’ve selected about [NNNNN] characters. But, we can only send about [NNNNN] characters to [Provider].

Comment 4

[Ed Lee :Mardak]

would be good to add glean/telemetry for when we show the message but can also split out to a separate patch/bug

we have existing telemetry for when we show prompts:
https://searchfox.org/mozilla-central/rev/53e8dfd81c32f1ab275516406ec06a68136aaef0/browser/components/genai/metrics.yaml#431-449
https://searchfox.org/mozilla-central/rev/53e8dfd81c32f1ab275516406ec06a68136aaef0/browser/components/genai/GenAI.sys.mjs#512-513

so maybe we can add an extra_key entry bool indicating the message was shown

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/948ae9cdc704
Add error message for when too many characters are selected before selecting a prompt r=Mardak,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,firefox-ai-ml-reviewers,emilio

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/948ae9cdc704

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 135.0a1 (2024-12-10).