1922558 - Include checkmark for show / hide shortcuts menu items to indicate current behavior on windows

Status: NEW

(Core :: Machine Learning, enhancement)

Description

[Ed Lee :Mardak]

Attachment: windows no checkmark.png

rares noted: The Show Shortcut when selecting text / Hide Shortcut when selecting text.. (from the Sidebar AI menu) we should have an indicator to know which one of them is selected.. maybe like a check mark ? or a color or something, I could add this as an Enhancement ?

this behavior already works on macos as we are setting [checked=true] from bug 1920102:
https://searchfox.org/mozilla-central/rev/f0b3dafb55f1e7904847f5dc889f131040789ba6/toolkit/themes/osx/global/menu.css#88,97,107

but windows requires [type=radio] or menuitem-iconic (to result in component with .menu-iconic-left):
https://searchfox.org/mozilla-central/rev/f0b3dafb55f1e7904847f5dc889f131040789ba6/toolkit/themes/windows/global/menu.css#130

Comment 1

[Ed Lee :Mardak]

i tried setting [type=radio] but given the current behavior of rebuilding but reusing the popup each time, it results in odd behavior of checkmark showing the first open but re-open loses checkmark. i believe part of this the menu opening logic to determine if there needs to be a gutter then optimized assuming items are unchanged