1922565 - [Menu Redesign] The menu sheet should close before opening Settings screen

Status: UNCONFIRMED

(Fenix :: Toolbar, defect, P3)

Description

[csheanyclone]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

Open the menu
Tap Settings

Actual results:

The page appears under the menu

Expected results:

The page appears over the menu

Comment 1

[csheanyclone]

Attachment: Screen_Recording_Firefox Nightly.mp4

Comment 2

[Chris Peterson [:cpeterson]]

Thanks for reporting this bug. We'll need to fix this bug before we can enable the new menu in Nightly.

Comment 3

[Iorga Gabriel]

Attachment: Bug 1922565 - [Menu Redesign] The menu sheet should close before opening Settings screen.

Comment 4

[Polly [:polly]]

hello, just looked at this patch. Thanks for raising!
But I don't think i understand the issue.
Is the requested behaviour that when you press settings, the z-index of the menu bottom sheet dialog should reorder itself to below the full screen content?
This is not what Material Design recommends, because it would be a jarring user experience to have the menu shift position in the visual stack.
It is recommended for modal bottom sheets to remain above other content.
See the google documentation here
So i think we should leave the current behaviour as it is.
(but if i have misunderstood what you are asking for, please let me know!)

Comment 5

[Iorga Gabriel]

I think this bug should be fixed by this task.

Comment 6

[Polly [:polly]]

ah ok... the linked task is about having a slide in animation from the browser content to the settings screen, behind the menu?
yeah that seems reasonable, thanks for sharing Gabriel! :)

Comment 7

[Chris Peterson [:cpeterson]]

We don't need to fix this transition animation for our menu redesign's MVP, so I'm moving this bug to our follow-up meta bug 1895936.