1922606 - Remove or update metrics expiring in Firefox 134: networking.cookie_c* before Gecko version gets increased to 134 on 2024-10-28

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P2)

Description

[telemetry-probes]

The following metrics will expire in the next Firefox Nightly release: version 134.

networking.cookie_chips_partition_limit_overflow
networking.cookie_count_part_by_key
networking.cookie_count_partitioned
networking.cookie_count_total
networking.cookie_count_unpart_by_key
networking.cookie_count_unpartitioned
networking.cookie_purge_entry_max
networking.cookie_purge_max

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their metrics.yaml definition file.
2. If one, some, or all of the metrics are still required, please submit a patch to extend their expiry.

If you have any problems, please ask for help on the #glean Matrix room or the #data-help Slack channel.
We'll give you a hand.

Your Friendly Neighbourhood Glean Team

---

This bug was auto-filed by probe-scraper.

Comment 1

[edgul]

We should extend these by at least 6 months.

Comment 2

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

Feel free to extend them yourself. It's not clear whether a contributor will submit a patch in time.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Tracking because netwerk/cookie/test/unit/test_chips_partition_capping.js and test_no_expired_metrics.py check for this.

Comment 4

[Oskar Mansfeld]

Hey, I could take this. 6 months extension would mean release 138, correct? Just double checking, this is basically just editing the expires keyword in metrics.yaml for the relevant metrics, right?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

A development cycle is 4 weeks in general, a bump by 4 versions pushes the expiration date ~4 months into the future. In practice, version 134 rolls out in ~2 weeks (133 development cycle) + 4 weeks (134 central development cycle) + 4 (beta) = 10 weeks. With version 138, the expiration happens in half a year.

The Herald bot will comment on the patch and request some classification data to be added as tags (example).

Comment 6

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

Thanks Oskar. Let's bump it by either 6 or 12 releases.

Comment 7

[edgul]

12 would probably be better to get longer coverage while we roll out 3PCD.

this is basically just editing the expires keyword in metrics.yaml
We also need to update the bugs and data_reviews sections of the metric.yaml

We also need to attach a data extension request to the bug, this one for example. See also https://github.com/mozilla/data-review/blob/main/renewal_request.md

Thanks Oskar!

Comment 8

[Oskar Mansfeld]

Attachment: 1922606_renewal.md

Comment 9

[Oskar Mansfeld]

Attachment: Bug 1922606 - Extended networking metrics expiring in release 134 to release 146, r=#necko

Comment 10

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

Oskar, could you rebase this on top of the latest mozilla-central and update the patch?
Landing it failed due to conflicts: https://lando.services.mozilla.com/D225222/

Comment 11

[Oskar Mansfeld]

Just rebased and updated the patch. Let me know if it works.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5eb3e7b97ea
Extended networking metrics expiring in release 134 to release 146, r=cookie-reviewers,edgul

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f5eb3e7b97ea