1922623 - [UX Follow] Styling updates for the shortcut popup

Status: RESOLVED FIXED

(Core :: Machine Learning: General, enhancement, P1)

Description

[Eric Pang [:epang] UX]

A collection of styling updates to match the visuals specs including:

Icon before hover

• Increase the size to 34x34px
• Add shadow (use the same shadow as the drop down panel)
• Change the corner radius to 4px
• Update background colour to: --arrowpanel-background << this will be done in bug 1923858
• Increase spacing between the shortcut icon and drop down (3px spacing)

Icon with hover ( with drop down)

• Add hover state - same colour as other icon hover states, if possible change the hover radius to 2px so it visually fits inside the 4px radius of the shortcut

See visual spec here.

The current shortcut is blending into the background a bit too much. These updates will help it be more visible.

Comment 1

[Eric Pang [:epang] UX]

Attachment: shortcut styling.png

Comment 2

[Nick]

Attachment: Bug 1922623 - [UX Follow] Styling updates for the shortcut popup r=Mardak!

This is round 1 (easy changes) for this enhancement have some questions for design to continue other callouts.

Comment 3

[Nick]

Attachment: Bug 1922623 - [UX Follow] Styling updates for the shortcut popup r=Mardak!

These are design enhancements and fixes for the shortcut to take into account addon theme and system settings

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/256c0878fcfd
[UX Follow] Styling updates for the shortcut popup r=Mardak,desktop-theme-reviewers,tabbrowser-reviewers,firefox-ai-ml-reviewers,dao

Comment 5

[Atila Butkovits]

Backed out for causing failures at test_show_chat_entrypoint.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/89285afd6c3a38a88c71b9782c19276843b254f8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=256c0878fcfdfbc53b552c1f970f00292cc214a4&selectedTaskRun=fK5OTUyhQ--h83snxqS4sw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=488520993&repo=autoland&lineNumber=5867
https://treeherder.mozilla.org/logviewer?job_id=488519760&repo=autoland&lineNumber=3854

Comment 6

[Nick]

Tests and bugs have been fixed going to attempt again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ebfc453e17d
[UX Follow] Styling updates for the shortcut popup r=Mardak,desktop-theme-reviewers,tabbrowser-reviewers,firefox-ai-ml-reviewers,dao

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5ebfc453e17d