1922657 - Allow all ToBigInt values in memory64 JS parameters

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P1)

Description

[Ben Visness [:bvisness]]

A spec update was recently merged to make sure that ToBigInt was used for IndexValue params in the memory64 JS API. We need to update our implementation to reflect this.

Comment 1

[Ben Visness [:bvisness]]

Attachment: Bug 1922657: wasm: Rename "index type" to "address type" internally. r=rhunt

This change in terminology affects all our code, but this patch does not
yet touch the "index" parameter in memory and table descriptors.

Comment 2

[Ben Visness [:bvisness]]

Attachment: Bug 1922657: wasm: Check for "address" instead of "index". r=rhunt

This updates memory/table descriptors and type reflection to use
"address" instead of "index".

Depends on D226505

Comment 3

[Ben Visness [:bvisness]]

Attachment: Bug 1922657: wasm: Accept all ToBigInt types. r=rhunt

Previously our implementation only accepted BigInt values, but the spec
now requires that ToBigInt is used and therefore that string and boolean
values may be accepted as well.

Depends on D226506

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 1922657: wasm: Update wast in spec test generator. r=rhunt

Some spec tests were added that have a new module
definition/instantiation syntax, and wast was changed to reflect this.
We handle this by not handling it, since it is irrelevant to memory64.
This will have to be addressed eventually when the rapidly-growing pile
of "wasm 3.0" spec tests are finally added to the main spec repo.

Depends on D226507

Comment 5

[Ben Visness [:bvisness]]

Attachment: Bug 1922657: wasm: Update to latest memory64 spec tests. r=rhunt

Depends on D226535

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/819e59143959
wasm: Rename "index type" to "address type" internally. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/f07ad9f4f3f5
wasm: Check for "address" instead of "index". r=rhunt
https://hg.mozilla.org/integration/autoland/rev/b92169f4a03b
wasm: Accept all ToBigInt types. r=rhunt

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/819e59143959
https://hg.mozilla.org/mozilla-central/rev/f07ad9f4f3f5
https://hg.mozilla.org/mozilla-central/rev/b92169f4a03b