Printing survey blurb is missing final period
Categories
(Fenix :: Experimentation and Telemetry, defect)
Tracking
(Not tracked)
People
(Reporter: dholbert, Unassigned)
References
Details
Attachments
(1 file)
70.15 KB,
image/png
|
Details |
Steps to reproduce
- Try to print a page in Fenix (3-dot-menu, scroll down, Print)
- Be lucky enough to be selected for our survey. (I'm not sure how to trigger this on-demand, but maybe there's a way.)
Expected behavior
When the survey invitation appears, its invitation-text should end with a period (after the last word, "sec.")
Actual behavior
The survey invitation text trails off without a final period:
Help make printing in Firefox better. It only takes a sec
Device information
- Firefox version: Nightly 133.0a1 2024-10-02
- Android device model: Pixel 8
- Android OS version: 14
Any additional information?
I don't know where the actually-displayed string lives, but I did found a copy in-tree that does include the trailing period (as expected):
https://searchfox.org/mozilla-central/rev/ce404cd26e52d09e6a48d664c1986da25df50484/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/microsurvey/ui/MicrosurveyRequestPrompt.kt#140
And the Jira Issue about this survey also includes a trailing period in its mockup.
But the actual survey invitation that I got in Firefox does not include that trailing period, somehow. Screenshot coming up.
twhite, do you have any ideas about what might be going on? Does the displayed prompt actually reference the
string from MicrosurveyRequestPrompt.kt#140 and truncate its last character somehow? Or do we have another copy of the string hosted in a web service somewhere that's slightly different and is missing the period at the end of the sentence?
Reporter | ||
Comment 1•5 months ago
|
||
Good catch Daniel, thanks for reporting.
The string used in MicrosurveyRequestPrompt.kt#140 is only used locally in the private preview function for the purposes of previewing the Compose UI. The actual string resource is here.
As this survey is only used for dev purposes, the missing period is acceptable, however this is a reminder to disable it in Nightly, thank you.
Description
•