Closed Bug 1922746 Opened 1 month ago Closed 1 month ago

Only show supported media actions in MacOS media center.

Categories

(Core :: Widget: Cocoa, task, P3)

Product:
Core
Component:
Widget: Cocoa
Version:
Firefox 133
Platform:
Desktop
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: floppa9, Assigned: floppa9)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1922746 - Only enable supported actions in macos media center r?alwu
48 bytes, text/x-phabricator-request
Details | Review

Currently the media controls in macos media center are always enabled, even if they are not supported by the current media session.

OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Assignee: nobody → floppa9
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Blocks: 1922220
Component: Audio/Video: Playback → Widget: Cocoa
Severity: -- → S3
Priority: -- → P3
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/289a8229aa60 Only enable supported actions in macos media center r=alwu

Backed out for causing build bustages in MediaHardwareKeysEventSourceMacMediaCenter.mm.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/widget/cocoa/MediaHardwareKeysEventSourceMacMediaCenter.mm:309:68: error: reference to type 'const NSSize' (aka 'const CGSize') could not bind to an rvalue of type 'std::nullptr_t'
Flags: needinfo?(floppa9)
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18c41d3876ce Only enable supported actions in macos media center r=alwu
Flags: needinfo?(floppa9)

https://hg.mozilla.org/mozilla-central/rev/18c41d3876ce

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: