1922773 - The CSD restore button is missing in some themes

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P2)

Description

[Airat Makhmutov]

Attachment: no-restore-button-bug.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0

Steps to reproduce:

1. Open firefox on Mate with BlueMenta theme
2. Expand to full screen

The bug is also reproduced on thunderbird.
Fix for thunderbird :

thunderbird/browser/themes/linux/browser.css | 2 +-
thunderbird/comm/mail/themes/linux/mail/messenger.css | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/thunderbird/browser/themes/linux/browser.css b/thunderbird/browser/themes/linux/browser.css
index 963a33af855..d4de1a507ac 100644
--- a/thunderbird/browser/themes/linux/browser.css
+++ b/thunderbird/browser/themes/linux/browser.css
@@ -272,21 +272,21 @@
order: env(-moz-gtk-csd-maximize-button-position);

.toolbarbutton-icon {
-moz-default-appearance: -moz-window-button-maximize;
background-image: url(chrome://browser/skin/window-controls/maximize.svg);
}
}

.titlebar-restore {
order: env(-moz-gtk-csd-maximize-button-position);

.toolbarbutton-icon {

• -moz-default-appearance: -moz-window-button-restore;

• -moz-default-appearance: -moz-window-button-maximize;
  background-image: url(chrome://browser/skin/window-controls/restore.svg);
  }
  }

@media not (-moz-gtk-csd-maximize-button) {
.titlebar-restore,
.titlebar-max {
display: none;
}
}
diff --git a/thunderbird/comm/mail/themes/linux/mail/messenger.css b/thunderbird/comm/mail/themes/linux/mail/messenger.css
index bdabab82c63..f070717a7ff 100644
--- a/thunderbird/comm/mail/themes/linux/mail/messenger.css
+++ b/thunderbird/comm/mail/themes/linux/mail/messenger.css
@@ -196,21 +196,21 @@

.toolbarbutton-icon {
-moz-default-appearance: -moz-window-button-maximize;
background-image: url(chrome://messenger/skin/window-controls/maximize.svg);
}
}

.titlebar-restore {
order: env(-moz-gtk-csd-maximize-button-position);

.toolbarbutton-icon {

• -moz-default-appearance: -moz-window-button-restore;

• -moz-default-appearance: -moz-window-button-maximize;
  background-image: url(chrome://messenger/skin/window-controls/restore.svg);
  }
  }

@media not (-moz-gtk-csd-maximize-button) {
.titlebar-max,
.titlebar-restore {
display: none;
}
}

2.42.2

But then all other themes will have an extension icon instead of a restore.

Actual results:

The restore button is not displayed.

Expected results:

The restore button with the extension icon is displayed, since there is no recovery icon in the theme.

Comment 1

[Airat Makhmutov]

Attachment: thunderbird-fix-missing-restore-button.patch

Comment 2

[maciek4231]

Can confirm on KDE Plasma 6 as well. Both snap and flatpak versions have restore button themed incorrectly (tested on 2 different machines). However, .deb version from mozilla ppa doesn't have this issue. The problem is only present with title bar turned off

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Can you test stock Mozilla binaries?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_Nightly_binaries
Thanks.

Comment 4

[Airat Makhmutov]

The bug is reproduced on the firefox-136.0a1

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

So stock Mozilla binaries fails but deb version from mozilla ppa works? Is that correct?

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Also does it help if you change Icon theme?

Comment 7

[:gerard-majax]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #5)

So stock Mozilla binaries fails but deb version from mozilla ppa works? Is that correct?

if so we can remove blocking snap/flatpak i guess

Comment 8

[Airat Makhmutov]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #6)

Also does it help if you change Icon theme?

Yes, it will help.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #5)

So stock Mozilla binaries fails but deb version from mozilla ppa works? Is that correct?

I have not tested the deb version from mozilla ppa.

Comment 9

[Airat Makhmutov]

The bug was fixed in 140. Now buttons are the same in all themes in mate.
Close bug as a fixed please.

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Okay, Thanks.