1922877 - Online BoaJS Playground, is 1.7x slower than Chrome, spends a ton of time in non-ion path and has tons of Bailouts (some bailouts in MonomorphicInlinedStubFolding )

Status: RESOLVED DUPLICATE of bug 1922926

(Core :: JavaScript Engine, task, P3)

Description

[Mayank Bansal]

Attachment: d3.v3.min.js

Go to https://boajs.dev/playground
Copy-paste the sample text (minimized d3.js source)

AR:
Nightly: https://share.firefox.dev/3TWrl7X (2.6s)
Chrome: https://share.firefox.dev/3BAKgiq (1.5s)

This DOM worker spends a lot of time in non-ion and has continuous Bailouts.

Feel free to close as INVALID.

Comment 1

[Mayank Bansal]

i havent seen bailouts in monomorphic inlining before in profiles, so i renamed this bug to reflect that.

Comment 2

[Mayank Bansal]

Looks like the SpiderMonkey WASI demo uses similar things.

On https://mozilla-spidermonkey.github.io/sm-wasi-demo/ , if I copy-paste the attached text, I get the following :

Nightly: https://share.firefox.dev/3zYzl1w
Chrome: https://share.firefox.dev/3UbaZJ0

The copy-pasting part shows similar rope flattening time, and the actual execution has bailouts.

Comment 3

[Jan de Mooij [:jandem]]

I looked at this a little but didn't see anything obvious. Bug 1922926 might improve the editor performance a bit.

Comment 4

[Mayank Bansal]

Nothing interesting in the profile from comment #2 too?

Edit: With the try build of substring03, I get this profile from STR of comment #2: https://share.firefox.dev/3U9FpLJ

Comment 5

[Mayank Bansal]

(In reply to Mayank Bansal from comment #0)

Created attachment 9429108 [details]
d3.v3.min.js

Go to https://boajs.dev/playground
Copy-paste the sample text (minimized d3.js source)

AR:
Nightly: https://share.firefox.dev/3TWrl7X (2.6s)
Chrome: https://share.firefox.dev/3BAKgiq (1.5s)

This DOM worker spends a lot of time in non-ion and has continuous Bailouts.

Feel free to close as INVALID.

With the Try build of Substring03: https://share.firefox.dev/4f2BAjb (The copy-paste bit looks to be faster than chrome here. 330ms Vs 500ms)

Comment 6

[Mayank Bansal]

Profile with hte latest Nightly: https://share.firefox.dev/4dSybmj
The "pasting code" part has become almost instantaneous now.

I am adding dependency on bug 1922926. I have left this bug open for now because we are still slower in "running" the script. But please feel free to close if there is nothing more to do here.

Comment 7

[Mayank Bansal]

(In reply to Jan de Mooij [:jandem] from comment #3)

I looked at this a little but didn't see anything obvious. Bug 1922926 might improve the editor performance a bit.

Nothing obvious to fix -> Dupe it over to bug 1922926.