1922934 - Regression: The "Generate OpenPGP Key" window on XFCE is too large

Status: VERIFIED FIXED

(MailNews Core :: Security: OpenPGP, defect, P3)

Description

[Airat Makhmutov]

Steps to reproduce:

1. Open Thunderbird on XFCE
2. Tools -> OpenPGP Key Manager
3. Generate -> New Key Pair

Thunderbird version: 128.3.0esr

Actual results:

A very long window opens, and the bottom buttons are off the screen.
On the KDE the window expands from the top to the bottom of the screen and the bottom buttons are visible.
The bug is not reproducible on version 115.15.0.

Expected results:

A normally sized window will open, where the bottom buttons (Cancel and Generate Key) will be visible.

Comment 1

[Airat Makhmutov]

Attachment: firefox-pgp-manager-bug.png

Comment 2

[Magnus Melin [:mkmelin]]

Maybe from bug 1733086.
(The dialog shows full height, ok, for me, but I'm not using xfce)

Comment 3

[Kai Engert [:KaiE:]]

Tested with XFCE. Confirm the dialog unnecessarily uses the whole height of the screen.

Who got the UI skills to understand why this is happening?
Thanks!

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1922934 - Reduce the height of the Create key dialog. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/823f2a287ca0
Reduce the height of the Create key dialog. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1922934-key-wizard-ESR.patch

[Approval Request Comment]
User impact if declined: Key creation dialog will be much too tall
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Low

Comment 7

[Corey Bryant]

Comment on attachment 9434470 [details] [diff] [review]
1922934-key-wizard-ESR.patch

[Triage Comment]
Approved for esr128

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 128.4.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/2a5bc86899c4

Comment 9

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed with 133.0b3(20241107210012) using XFCE 4.18 (VM).