1922974 - Do not define misleading image.jxl.enabled unless MOZ_JXL is defined

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, task)

Description

[Masatoshi Kimura [:emk]]

See bug 1806525 for example.

Comment 1

[[:Kizance]]

This is not only misleading, if you set image.jxl.enabled = true a browser (noticed issue on dev 145.0b9 (64-bit)) that does not support jxl it will sometimes (inline images but not direct access) still send the http accept header jxl,image and then fail to render the image with the server actually responds with jxl images.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1922974 - Add MOZ_JXL guard to pref and nsHTTPHandler r=tnikkel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/de82861eb089
https://hg.mozilla.org/integration/autoland/rev/a6092ef63390
Add MOZ_JXL guard to pref and nsHTTPHandler r=tnikkel,necko-reviewers,jesup

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b84a273a454
https://hg.mozilla.org/integration/autoland/rev/6e5ed515f0d8
Revert "Bug 1922974 - Add MOZ_JXL guard to pref and nsHTTPHandler r=tnikkel,necko-reviewers,jesup" for causing build bustages @nsImageModule.cpp.

Comment 5

[agoloman]

Backed out for causing bustages @nsImageModule.cpp.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e1bdafd20a5
https://hg.mozilla.org/mozilla-central/rev/98c6a22fd4c3
Add MOZ_JXL guard to pref and nsHTTPHandler r=tnikkel,necko-reviewers,jesup

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/98c6a22fd4c3