1923148 - [Outreachy] Add placeholder implementation for Iterator.ZipKeyed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Dan Minor [:dminor]]

This bug is about adding a placeholder implementation for the Iterator.zipKeyed method of the joint iteration proposal. The steps to do this are:

1. Make sure that you are able to build SpiderMonkey and run the existing tests. There are instructions here. You want to run the jstests, using this command ./mach jstests.
2. In Iterator.js add a placeholder method for IteratorZipKeyed. We use NIGHTLY_BUILD so this will only be built for Nightly, and will not be available in release. Returning false means this method will fail all the time for now.

#ifdef NIGHTLY_BUILD
/**
 * Iterator.zipKeyed ( iterables [, options] )
 *
 * https://tc39.es/proposal-joint-iteration/#sec-iterator.zipkeyed
 */
function IteratorZipKeyed(predicate) {
  return false;
}
#endif

3. Add the new function as a static method on Iterators. Please use #ifndef NIGHTLY_BUILD / #endif here as well.
4. You can check that your new method is available in the shell, e.g. print(Iterator.zipKeyed) from the JavaScript shell.
5. The final step is to remove it from the Iterator object when the pref for joint iteration is not enabled. There's an example of how to do this in this patch. Note that you'll have to add zipKeyed to CommonPropertyNames.h.
6. Make sure you can still build and run the tests.
7. Once the tests all pass for you, you can commit your changes. Your commit message should look like: Bug X - Add placeholder for Iterator.zipKeyed; r=dminor!, where X is the number for this bug.
8. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[Dan]

I am looking into this.

Comment 2

[Dan]

As soon as this is merged (https://phabricator.services.mozilla.com/D224467), I will make a patch

Comment 3

[Dan]

Attachment: Bug 1923148 - Add placeholder for Iterator.zipKeyed; r=dminor!

Comment 4

[Dan]

Attachment: Bug 1923148 - Add placeholder for Iterator.zipKeyed; r=dminor!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55c7f2699afc
Add placeholder for Iterator.zipKeyed; r=dminor

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/55c7f2699afc