1923186 - Enable topic labels for US/CA

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Enable topic labels in CA and US in train, so we can turn off the rollout

https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1874

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1923186 - Enable topic labels for US/CA r?#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/494fe1ee7b14
Enable topic labels for US/CA r=home-newtab-reviewers,thecount

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/494fe1ee7b14

Comment 4

[Donal Meehan [:dmeehan]]

:maxx anything you want to call in a release note? (Process info)

Comment 5

[Maxx Crawford [:maxx]]

Confirmed with product. This feature flip does not warrant a rel note mention. When we roll out the larger effort (topic selection), we can include it. Thanks for asking!

Comment 6

[Maxx Crawford [:maxx]]

Attachment: Bug 1923186 - Enable topic labels for US/CA r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D224829

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Only users who have had the feature turned over via rollout will see this feature.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: In a fresh profile, open up the new tab page in a region where Recommend Stories (pocket) are enabled/visible. Each story (not adverts) should have a topic label in the top left corner.
• Risk associated with taking this patch: Low.
• Explanation of risk level: This feature is already "enabled" via a rollout to 100%. We just flipping the default pref.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Only users who have had the feature turned over via rollout will see this feature.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: In a fresh profile, open up the new tab page in a region where Recommend Stories (pocket) are enabled/visible. Each story (not adverts) should have a topic label in the top left corner.
• Risk associated with taking this patch: Low.
• Explanation of risk level: This feature is already "enabled" via a rollout to 100%. We just flipping the default pref.
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Enabling the default pref for users to see the Recommend Stories card labels sooner will enable us to conclude the rollout more quickly
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: In a fresh profile, open up the new tab page in a US or CA. Each story (not adverts) should have a topic label in the top left corner.
• Risk associated with taking this patch: Low.
• Explanation of risk level: This feature is already "enabled" via a rollout to 100%, early beta, and nightly for quite a while. We are enabling the default pref.
• String changes made/needed: No
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9ab2e1e8c77