Sometimes tag data from an IRC server doesn't contain a pair
Categories
(SeaMonkey :: Chat, defect)
Tracking
(seamonkey2.53? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
892 bytes,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Usually tag data from an irc server contains semi-colon separated tags in key=value pairs but sometimes a tag just contains a key and no value, so decodeTagData needs to deal with that circumstance
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: further tags in that set of tag data are ignored
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
One server network that produces some tag pairs without values is freenode
|
||
Updated•2 months ago
|
|
|
||
Comment 3•2 months ago
|
||
Comment on attachment 9429469 [details] [diff] [review]
1923211-irc-fix-decodeTagData-25320.patch
lgtm. Copud probably be simplified with an optional chaining operator as discussed.
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b3c7f8149c37
Use blank value as key if tag data from a IRC server doesn't contain a pair. r=frg
Description
•