1923219 - Remove unused code from connection-xpcom.js

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

There's lots of code that is there to support early platforms that can be removed from connection-xpcom.js
Use contract ID for the STS.
Only binary streams are now used.
Only strictSSL is now used.
No need to test for the type of input-stream-pump init parameters.
No missing result code for NS_BASE_STREAM_WOULD_BLOCK

Comment 1

[Ian Neal]

Attachment: 1923219-irc-connection-xpcom-tidy-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1923219-irc-connection-xpcom-tidy-v1_1-25320.patch

Do a bit more tidying of the file.

Comment 3

[Ian Neal]

Attachment: 1923219-irc-connection-xpcom-tidy-v1_2-25320.patch

Changes since previous patch:

• Remove now unused compareVersions function

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9433473 [details] [diff] [review]
1923219-irc-connection-xpcom-tidy-v1_2-25320.patch

lgtm

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b21d901c0771
Remove unused code from connection-xpcom.js. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/26432a662650c2b5c8b23afbb540ab3323391a92
Remove unused code from connection-xpcom.js. r=frg a=frg