Closed Bug 1923224 Opened 3 months ago Closed 2 months ago

Switch from using arrayContains helper to using JS Array includes method

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53? affected)

RESOLVED FIXED
Tracking Status
seamonkey2.53 ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.20)

Attachments

(1 file, 1 obsolete file)

Remove the helper arrayContains from utils.js and use JS Array includes method.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9429484 - Flags: review?(frgrahl)
Attachment #9429484 - Flags: approval-comm-release?

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9429484 - Attachment is obsolete: true
Attachment #9429484 - Flags: review?(frgrahl)
Attachment #9429484 - Flags: approval-comm-release?
Attachment #9429488 - Flags: review?(frgrahl)
Attachment #9429488 - Flags: approval-comm-release?

Comment on attachment 9429488 [details] [diff] [review]
1923224-irc-remove-arrayContains-25320.patch

lgtm

Attachment #9429488 - Flags: review?(frgrahl)
Attachment #9429488 - Flags: review+
Attachment #9429488 - Flags: approval-comm-release?
Attachment #9429488 - Flags: approval-comm-release+
Whiteboard: SM2.53.20

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/35bfae195488
Switch from using arrayContains helper to using JS Array includes method. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: