Switch from using arrayIndexOf helper to using JS Array includes and indexOf methods
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
17.52 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Remove the helper arrayContains from utils.js and use JS Array includes and indexOf methods.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
I've picked up one spot where this.channelTypes doesn't always exist, there may be other places where need to check the existence of the array we are looking at.
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9429490 [details] [diff] [review]
1923225-irc-remove-arrayIndexOf-25320.patch
lgtm
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8109258b4a28
Switch from using arrayIndexOf helper to using JS Array includes and indexOf methods. r=frg
Description
•