1923227 - Switch from using arrayRemoveAt and arrayInsertAt helpers to using JS Array splice and unshift methods

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

Remove the arrayRemoveAt and arrayInsertAt helpers from utils.js and use JS Array splice and unshift methods instead.

Comment 1

[Ian Neal]

Attachment: 1923227-irc-remove-arrayRemoveInsert-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9429492 [details] [diff] [review]
1923227-irc-remove-arrayRemoveInsert-25320.patch

lgtm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0be4831e641
Switch from using arrayRemoveAt and arrayInsertAt helpers to using JS Array splice and unshift methods. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/554e34a81152fd972113b2a3f0d726f3d7bb3993
Switch from using arrayRemoveAt and arrayInsertAt helpers to using JS Array splice and unshift methods. r=frg a=frg