1923232 - Switch from using keys helper to using JS Object keys method

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

Remove keys helper from utils.js and use JS Object keys method instead.

Comment 1

[Ian Neal]

Attachment: 1923232-irc-remove-keys-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9429494 [details] [diff] [review]
1923232-irc-remove-keys-25320.patch

lgtm. r/a+
Not an 1:1 replacement because the for in loop would be enumerate properties in the prototype chain as well according to documentation but suspect it doesn't matter or we would have seen fallout.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe4c6cdb0ede
Switch from using keys helper to using JS Object keys method. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9a0c76bc6133fa4398531f88db9e19f847e8b463
Switch from using keys helper to using JS Object keys method. r=frg a=frg