1923238 - [Unified Ads API Integr] change endpoint hit for unified ads DELETE request

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

Right now we are hitting "v1/ads" with a DELETE request, and it should be a DELETE request to "v1/delete_user"

Comment 1

[Scott [:thecount] Downe]

To test:

1. Ensure you can see spocs on newtab and Parent brocess Browser Toolbox.
2. Set browser.newtabpage.activity-stream.unifiedAds.spocs.enabled to true
3. Turn off sponsored topsites.
4. Turn off sponsored stories.
   Expected: should see a DELETE newtwork request to delete_user, it should be a 200, that matches this screenshot:

Comment 2

[Scott [:thecount] Downe]

Attachment: image.png

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1923238 - Newtab change endpoint hit for unified ads DELETE request

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d36311fb9eb9
Newtab change endpoint hit for unified ads DELETE request r=home-newtab-reviewers,maxx

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d36311fb9eb9

Comment 6

[Maxx Crawford [:maxx]]

Attachment: Bug 1923238 - Newtab change endpoint hit for unified ads DELETE request

Original Revision: https://phabricator.services.mozilla.com/D224884

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: This would impact the timeline for unified ads experiments which delays the feature being released to users
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps outlined in bug comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1923238#c1
• Risk associated with taking this patch: Low
• Explanation of risk level: All code related to this experiment (and this one line change) are behind prefs. This code will only be exposed to users in the experiment branch of the unified ads experiment
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/00b82e90c4e9

Comment 9

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the DELETE request is successfully sent when both checkboxes are unchecked on the latest Nightly 133.0a1 (Build ID 20241013211859) and latest Beta 132.0b6 (Build ID 20241011091831) using Windows 10, macOS 14.5, Ubuntu 24.04