1923264 - The update selection could check for unsupported updates

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Pier Angelo Vendrame]

On Tor Browser, we moved the check for unsupported updates on the client rather than the update server to limit the data we collect from users.
We noticed that UpdateService.#selectUpdate could check whether an update is unsupported, and take it instead of a more recent, but unsupported, update.
I don't know it this is ever a case for Firefox, since the unsupported="true" attribute is set on the update responses by the server, if I understand correctly.

Comment 1

[Pier Angelo Vendrame]

Attachment: Bug 1923264 - Discard unsupported updates in selectUpdate. r?#application-update-reviewers

UpdateService.#selectUpdate currently chooses always the most recent
update even when unsupported and an older but supported one is
available.
This commit makes #selectUpdate discard the unsupported update if a
supported alternative is found.

Depends on D224895

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2e038b6d6cc
Discard unsupported updates in selectUpdate. r=bytesized,nalexander

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e2e038b6d6cc