1923273 - -Werror=dangling-pointer= - nsTObserverArray.h error: storing the address of local variable ‘__for_begin’

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

    inlined from ‘nsAutoTObserverArray<T, N>::STLIteratorRange<Iterator, U>::iterator nsAutoTObserverArray<T, N>::STLIteratorRange<Iterator, U>::begin() const [with Iterator = nsAutoTObserverArray<nsTObserverArray<RefPtr<mozilla::dom::CloseWatcher> >, 0>::BackwardIterator; U = const nsTObserverArray<RefPtr<mozilla::dom::CloseWatcher> >; T = nsTObserverArray<RefPtr<mozilla::dom::CloseWatcher> >; long unsigned int N = 0]’ at /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsTObserverArray.h:457:52,
    inlined from ‘bool mozilla::dom::CloseWatcherManager::Contains(const mozilla::dom::CloseWatcher&) const’ at /root/firefox-gcc-last/dom/closewatcher/CloseWatcherManager.cpp:82:50:
/root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsTObserverArray.h:282:25: error: storing the address of local variable ‘__for_begin’ in ‘*MEM[(const struct nsAutoTObserverArray & *)&D.696792].nsAutoTObserverArray<nsTObserverArray<RefPtr<mozilla::dom::CloseWatcher> >, 0>::<anonymous>.nsTObserverArray_base::mIterators’ [-Werror=dangling-pointer=]
  282 |       aArray.mIterators = this;
      |       ~~~~~~~~~~~~~~~~~~^~~~~~

Comment 1

[[:sergesanspaille]]

It's a false positive: the reference is dropped upon destruction of this, see

https://searchfox.org/mozilla-central/source/xpcom/ds/nsTObserverArray.h#290