1923647 - make `--push-to-lando` the default behaviour of `mach try`

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, task)

Description

[Connor Sheehan [:sheehan]]

With bug 1856590 now fixed, we have resolved the main blocker for adoption of --push-to-lando as the default behaviour of mach try.

We should add a new --push-to-vcs flag which does the inverse of --push-to-lando to allow developers to push to hg.mozilla.org directly. We will warn about the changed default and log a hint about the flag when mach try is run.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: Bug 1923647: make `--push-to-lando` the default behaviour of `mach try` r?ahochheiden,ahal

Add a new --push-to-vcs flag which can be used to tell mach try
to push changes to hgmo directly via version control. Switch the
main if statement in push_to_try to use this flag instead of
the --push-to-lando flag, effectively making --push-to-lando
the default behaviour of mach try. Users and automation accounts
can force mach try to push directly by setting MACH_TRY_PUSH_TO_VCS=1
in the environment for mach try.

Keep the --push-to-lando flag around for the time being and log
a message indicating that the flag is deprecated since Lando try
is now the default behaviour. After a short period of time we will
remove the log message and the old flag. Also log the warning when
the --push-to-vcs flag is not used so developers who were previously
not using --push-to-lando have a hint as to why the push behaviour
has changed and how they can revert it if necessary.

Since mach try perf requires the SHA of the pushed commit and cannot
submit to Lando, explicitly set push_to_vcs=True when it calls
push_to_try to work around this.

Set push_to_vcs=True in test_again.py::test_try_again so the
push does not hang while waiting for input in the browser. This
preserves the existing test behaviour.

Update test_push.py to remove the --push-to-lando flag to avoid
confusion about the flag in the future.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: Bug 1923647: update `snap-test` docs to remove reference to `--push-to-lando` r?gerard-majax

Since --push-to-lando is now the default behaviour we can remove
the reference to it in the Updating reference screenshots section
of the README.

Comment 3

[Connor Sheehan [:sheehan]]

:marco, :jgraham, the patches I've just posted make --push-to-lando the default behaviour for mach try. I've also added a --push-to-vcs flag and MACH_TRY_PUSH_TO_VCS=1 environment variable to instead push directly to hgmo via Mercurial/cinnabar.

I am aware that both of you own automation that creates try pushes (code-review-bot and WPTSync), and we aren't ready to enable pushes to Lando try from automation. You will need to set the environment variable in your automation to continue pushing to try directly after the patch lands. Could you let me know when you have set that up so we can avoid breaking those tools?

Comment 4

[Marco Castelluccio [:marco]]

Sebastian, could you confirm when the change has been done and deployed on the code review bot?

Comment 5

[Bastien Abadie [:bastien]]

I think no changes are needed on the code-review bot as it pushes directly to try repo, without using ./mach try or any other mach command.

Comment 6

[James Graham [:jgraham]]

wpt-sync should now be updated to pass in --push-to-vcs.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12feda813808
make `--push-to-lando` the default behaviour of `mach try` r=ahochheiden,ahal,perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/d8007958cc9a
update `snap-test` docs to remove reference to `--push-to-lando` r=gerard-majax

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/12feda813808
https://hg.mozilla.org/mozilla-central/rev/d8007958cc9a