1923686 - Accidentally searching URL when scotch bonnet is enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Moritz Beier [:mbeier]]

Attachment: example

When scotch bonnet is enabled and searching with a non application provided engine, search mode stays activated after the search even though the search terms are not persisted. When the user now tries editing the URL to adjust his query, it searches for the URL instead of opening it.

A possible solution would be to leave search mode after a search with a search engine where persistent search terms are not supported.

Comment 1

[Chris Bellini (:cbellini)]

We will exit search mode for search engines in which persistent search terms are not supported.

Comment 2

[Yazan Al Macki [:yazan]]

Attachment: Bug 1923686 - Exit search mode for non app-provided search engines. r?jteow

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70d6b0ceb39f
Exit search mode for non app-provided search engines. r=jteow,urlbar-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/70d6b0ceb39f

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:yazan, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-10-09 Nightly build on macOS 14.
Verified as fixed on Firefox Nightly 135.0a1 and Firefox 134.0b1 on macOS 14, Windows 10, Ubuntu 22.