1923710 - [Outreachy] Replace sumprecise condition in JSObject.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dan Minor [:dminor]]

Bug 1923146 accidentally removed the check for sumPrecise in JSObject.cpp, we should add it back in here:

  if (key == JSProto_Math && !JS::Prefs::experimental_math_sumprecise() &&
      id == NameToId(cx->names().sumPrecise)) {
    return true;
  }

Comment 1

[Serah Nderi]

I'll work on this

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:moyotawanda, since you are the author of the regressor, bug 1923146, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Dan Minor [:dminor]]

Serah is already looking at this :)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1923146

Comment 5

[Serah Nderi]

Attachment: Bug 1923710 - Re-add sumPrecise check. r=syedbarimanjan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f03ea44806e
Re-add sumPrecise check. r=dminor

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9f03ea44806e