1923744 - Add telemetry for default browser native prompt

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, task)

Description

[:Gela]

Steps to reproduce

Expected behavior

Actual behavior

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

Comment 1

[:Gela]

Attachment: Bug 1923744 - Add telemetry for default browser native prompt

Comment 2

[twhite]

Attachment: Bug 1923744 - Add telemetry for the system set to default browser prompt

Comment 3

[:Gela]

Attachment: Bug 1923744 - Add telemetry for default browser native prompt

Original Revision: https://phabricator.services.mozilla.com/D225145

Comment 4

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: We won't have telemetry for native prompt
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a. It's just telemetry
• Risk associated with taking this patch: Very low, we're just collecting telemetry for a feature
• Explanation of risk level: Telemetry
• String changes made/needed: n/a
• Is Android affected?: yes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f72106b618f
Add telemetry for default browser native prompt r=rebecatudor273,amejiamarmol

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/1f72106b618f

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/496e0901559b

Comment 8

[Zac McKenney [:zmckenney]]

As was flagged by Tom in the PR, this is indeed causing crashes for custom tabs due to kotlin.UninitializedPropertyAccessException: lateinit property homeFragment has not been initialized. I know we've landed this and uplifted into Beta but I think we should either back this out or have a fix very shortly and uplift that.

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/6a2518f67e94
Backed out changeset 1f72106b618f on request for causing crashes. a=backout

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3739972a588a

Comment 11

[:Gela]

Attachment: Bug 1923744 - Add telemetry for default browser native prompt

Comment 12

[:Gela]

This was backed out every where last week, I have a follow up patch with fixes that will be going into Nightly once approved.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa0a97758df
Add telemetry for default browser native prompt r=android-reviewers,amejiamarmol

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5fa0a97758df