1923763 - Handle invalid `anchor()` values.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

Invalid if:

• Used outside of inset property
• Used in non-abspos positioning
• Keyword used for anchor side does not match physical side e.g. left: anchor(top)
• Anchor specified refers to itself e.g. anchor-name: --foo; anchor(--foo left). Possible since anchors can have anchors.

Need to give fallback in this case, or treat the entire property as invalid at compute time.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1923763: Part 1 - Enable sharing StylePositionProperty between C++ and Rust. r=#anchor-positioning-reviewers,#style

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1923763: Part 2 - Implement Anchor function resolution functions from Rust side. r=#anchor-positioning-reviewers,#style

Depends on D231255

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1923763: Part 3 - Implement anchor function resolution in math functions from Rust side. r=#anchor-positioning-reviewers,#style

Depends on D231256

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1923763: Part 4 - Implement a way to get anchor-function-resolved inset. r=#anchor-positioning-reviewers,#layout,#style

Depends on D231257

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1923763: Part 5 - Replace inset evaluations with anchor-resolved inset evaluations. r=#anchor-positioning-reviewers,#layout

Depends on D231258

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1923763: Part 6 - Adjust test expectations. r=#anchor-positioning-reviewers,#layout

Depends on D231259

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8018734b5491
Part 1 - Enable sharing StylePositionProperty between C++ and Rust. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/93e59980eac1
Part 2 - Implement Anchor function resolution functions from Rust side. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/d2139afa933b
Part 3 - Implement anchor function resolution in math functions from Rust side. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/0cc5e744c01a
Part 4 - Implement a way to get anchor-function-resolved inset. r=layout-reviewers,firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/2203e2c5268e
Part 5 - Replace inset evaluations with anchor-resolved inset evaluations. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a92a0bc6047f
Part 6 - Adjust test expectations. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/d55070e64ced
apply code formatting via Lando

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages in nsStyleStruct.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/layout/style/nsStyleStruct.cpp:1431:1: error: control reaches end of non-void function [-Werror=return-type]

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0554ce87d45
Part 1 - Enable sharing StylePositionProperty between C++ and Rust. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/1b116dd05e95
Part 2 - Implement Anchor function resolution functions from Rust side. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a27ef6564c6a
Part 3 - Implement anchor function resolution in math functions from Rust side. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/99c81ec1fcb6
Part 4 - Implement a way to get anchor-function-resolved inset. r=layout-reviewers,firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/ef47cdd0c025
Part 5 - Replace inset evaluations with anchor-resolved inset evaluations. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/f21f52fd370b
Part 6 - Adjust test expectations. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/317477da15d1
apply code formatting via Lando

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d0554ce87d45
https://hg.mozilla.org/mozilla-central/rev/1b116dd05e95
https://hg.mozilla.org/mozilla-central/rev/a27ef6564c6a
https://hg.mozilla.org/mozilla-central/rev/99c81ec1fcb6
https://hg.mozilla.org/mozilla-central/rev/ef47cdd0c025
https://hg.mozilla.org/mozilla-central/rev/f21f52fd370b
https://hg.mozilla.org/mozilla-central/rev/317477da15d1