1923831 - [wdspec] Update window maximization tests to not expect the window to be the size of the screen on Wayland

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P2)

Description

[Alexandra Borovova [:Sasha]]

While working on the bug 1857571, I've noticed that [the window maximization, when calling window.maximize() command, increases the window size but not to the size of the screen (smaller than that) on Wayland when we expect to be the size of the screen or even slightly larger (see try push).

Also, a comment from the bug 1857571
(In reply to Martin Stránský [:stransky] (ni? me) from comment #27)

Yes I see the same results on Fedora 40. It's not guaranteed on Wayland that any app size/state request is accepted by compositor.

Comment 1

[Alexandra Borovova [:Sasha]]

It seems like we can not guarantee that the maximized window has the size of the screen, the Marionette logic works fine since we receive the event, so we can just update the tests for Wayland.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I assume this is only about our wdspec tests and no other wpt test of any other component.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1923831 - [wdspec] Use os data instead of mozinfo to identify Wayland.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1923831 - [wdspec] Update window maximization tests to not expect the window to be the size of the screen on Wayland.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1923831 - Mark minimization tests as failing on Wayland.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fd5f1828e65
[wdspec] Use os data instead of mozinfo to identify Wayland. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/4251a2ed50a8
[wdspec] Update window maximization tests to not expect the window to be the size of the screen on Wayland. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/571747a2c68b
Mark minimization tests as failing on Wayland. r=webdriver-reviewers,whimboo

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48818 for changes under testing/web-platform/tests

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7fd5f1828e65
https://hg.mozilla.org/mozilla-central/rev/4251a2ed50a8
https://hg.mozilla.org/mozilla-central/rev/571747a2c68b

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot