1923859 - Crash in [@ java.lang.UnsatisfiedLinkError: at org.mozilla.gecko.GeckoAppShell.isInteractiveWidgetDefaultResizesVisual(Native Method)]

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Donal Meehan [:dmeehan]]

Crash report: https://crash-stats.mozilla.org/report/index/6af9afbe-5a0c-4cb7-a363-3247c0241010

Top 10 frames:

0  org.mozilla.gecko.GeckoAppShell  isInteractiveWidgetDefaultResizesVisual  GeckoAppShell.java:-2
1  org.mozilla.geckoview.GeckoRuntime  isInteractiveWidgetDefaultResizesVisual  GeckoRuntime.java:1
2  org.mozilla.fenix.browser.BaseBrowserFragment  configureEngineViewWithDynamicToolbarsMaxHeight$app_fenixNightly  BaseBrowserFragment.kt:183
3  org.mozilla.fenix.browser.BaseBrowserFragment$NavigationButtonsCFR$3$11  invoke  BaseBrowserFragment.kt:8
4  org.mozilla.fenix.components.toolbar.navbar.NavigationBarKt  NavBar-KTwxG1Y  NavigationBar.kt:378
5  org.mozilla.fenix.components.toolbar.navbar.NavigationBarKt  BrowserNavBar  NavigationBar.kt:15
6  org.mozilla.fenix.browser.BaseBrowserFragment$NavigationButtonsCFR$3  invoke  BaseBrowserFragment.kt:173
7  androidx.compose.runtime.internal.ComposableLambdaImpl  invoke  ComposableLambda.jvm.kt:7
8  mozilla.components.compose.cfr.CFRPopupLayoutKt  CFRPopupLayout  CFRPopupLayout.kt:316
9  org.mozilla.fenix.browser.BaseBrowserFragment  NavigationButtonsCFR$app_fenixNightly  BaseBrowserFragment.kt:300

Comment 1

[Donal Meehan [:dmeehan]]

:petru could you help identify the regressor here, could it be Bug 1916154?

Comment 2

[Petru-Mugurel Lingurar [:petru]]

The cause of the crash is probably bug 1916154 indeed, it started to use a new API from Gecko which apparently can be missing at times 🤨

Unobfuscated stack trace:

java.lang.UnsatisfiedLinkError: No implementation found for boolean org.mozilla.gecko.GeckoAppShell.isInteractiveWidgetDefaultResizesVisual() (tried Java_org_mozilla_gecko_GeckoAppShell_isInteractiveWidgetDefaultResizesVisual and Java_org_mozilla_gecko_GeckoAppShell_isInteractiveWidgetDefaultResizesVisual__) - is the library loaded, e.g. System.loadLibrary?

   at org.mozilla.gecko.GeckoAppShell.isInteractiveWidgetDefaultResizesVisual(GeckoAppShell.java)
   at org.mozilla.geckoview.GeckoRuntime.isInteractiveWidgetDefaultResizesVisual(GeckoRuntime.java:1065)
   at org.mozilla.fenix.browser.BaseBrowserFragment.configureEngineViewWithDynamicToolbarsMaxHeight$app_fenixNightly(BaseBrowserFragment.kt:183)
   at org.mozilla.fenix.browser.BaseBrowserFragment$NavigationButtonsCFR$3$11.invoke(BaseBrowserFragment.kt:1721)
   at org.mozilla.fenix.browser.BaseBrowserFragment$NavigationButtonsCFR$3$11.invoke(BaseBrowserFragment.kt:1633)
   at org.mozilla.fenix.components.toolbar.navbar.NavigationBarKt.NavBar-KTwxG1Y(NavigationBar.kt:349)

Hiro, do you know how this could happen?

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

Based on breadcrumbs from Sentry this crash does not happen at the instant the app is opened/browser is visible but after some seconds, time in which Gecko should be loaded and available 🤔

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1923859 - Bail out if JNI isn't ready to be used in isInteractiveWidgetDefaultResizesVisual. r?#geckoview-reviewers

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Though I posted a patch, it's speculative based on a fix for a similar case (https://hg.mozilla.org/integration/autoland/rev/fb6f6155866e).

Anyways, I have totally no idea what's going on there. Given that the function isInteractiveWidgetDefaultResizesVisual is supposed to be used when the software keyboard is shown on a web site, which means Gecko itself should have been used, that's totally weird.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4d2777efdbc
Bail out if JNI isn't ready to be used in isInteractiveWidgetDefaultResizesVisual. r=geckoview-reviewers,m_kato

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f4d2777efdbc