1923928 - [Outreachy] Helper function formatting has gone sideways

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Something has happened and the auto formatting here has gone wrong -- notice the inconsistencies.

This could be just a "run clang-format on the file" bug.

Comment 1

[Dan Minor [:dminor]]

Like Mathew pointed out, the JS_FN_HELP blocks should all be aligned on the left hand side. If running clang-format doesn't help, please fix the formatting by hand.

There are instructions on how to get started building SpiderMonkey here: https://firefox-source-docs.mozilla.org/js/build.html.
Once you've made the changes, make sure you're still able to build SpiderMonkey. Then you can commit your changes. Your commit message should look like: Bug 1923928 - Fix helper function formatting; r=dminor!.

Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 2

[Dan]

I am looking into this issue.

Comment 3

[Dan]

Attachment: Bug 1923928 - Fix helper function formatting; r=dminor!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9bc26f4b569
Fix helper function formatting; r=dminor

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c9bc26f4b569