1924022 - TypeError: urlopen() got an unexpected keyword argument 'cafile'

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Mike Hommey [:glandium]]

The bootstrap tasks (they run bootstrap and build) fail on fedora 41 and 42, which have already upgraded to python 3.13.

Error running mach:
    mach --no-interactive bootstrap --application-choice browser
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file bootstrap`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
TypeError: urlopen() got an unexpected keyword argument 'cafile'
  File "/mozilla-unified/python/mozboot/mozboot/mach_commands.py", line 50, in bootstrap
    bootstrapper.bootstrap(command_context.settings)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/mozilla-unified/python/mozboot/mozboot/bootstrap.py", line 455, in bootstrap
    self.instance.ensure_rust_modern()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/mozilla-unified/python/mozboot/mozboot/base.py", line 633, in ensure_rust_modern
    self.install_rust()
    ~~~~~~~~~~~~~~~~~^^
  File "/mozilla-unified/python/mozboot/mozboot/base.py", line 702, in install_rust
    http_download_and_save(url, rustup_init, checksum)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/mozilla-unified/python/mozboot/mozboot/util.py", line 37, in http_download_and_save
    f = urlopen(url, cafile=certifi.where())

The urlopen documentation for python 3.13 says:

Changed in version 3.13: Remove cafile, capath and cadefault parameters: use the context parameter instead.

The context parameter was added to python 3.4.3, so we can safely switch.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1924022 - Use urlopen's context parameter instead of cafile.

The latter was removed in python 3.13.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Bootstrap Configuration' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d369655cf80a
Use urlopen's context parameter instead of cafile. r=firefox-build-system-reviewers,jcristau,ahochheiden

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d369655cf80a

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1924022 - Use urlopen's context parameter instead of cafile.

The latter was removed in python 3.13.

Original Revision: https://phabricator.services.mozilla.com/D225318

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1924022 - Use urlopen's context parameter instead of cafile.

The latter was removed in python 3.13.

Original Revision: https://phabricator.services.mozilla.com/D225318

Comment 7

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Failure do build with python 3.13 downstream or for local developers
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Build only
• String changes made/needed: N/A
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/168b1a4e0829